search

bradleyfay / py-Goldsberry

Python Package for facilitating analysis of NBA Data
MIT License
259 stars 67 forks source link

Not pulling 2015 data? #13

Closed hsharrison closed 8 years ago

hsharrison commented 8 years ago

It could very well be that I'm doing something wrong, but I can't seem to get any data from the current season. I'm able to infer that this data is indeed supplied by the API because I can get with nba_py, which is a much less convenient package.

bradleyfay commented 8 years ago

Can you paste your code so I can check exactly what lines I need to debug?

hsharrison commented 8 years ago

Nevermind, after looking through the code it looks like my mistake was not overriding the default season='2014' on some functions. By overriding this default everything works as expected.

bradleyfay commented 8 years ago

Cool. Your finding is useful. I need to update the default for this season and make that aspect more explicit.

Thanks for sharing and ease share more.

hsharrison commented 8 years ago

I was also fooled by the GameIDs function which does not include any 2015 games. But looking at the associated issue it appears that requires some manual updating on your part?

bradleyfay commented 8 years ago

Yeah. There is a systematic way to create them but there isn't a database to pull them from.

At least not that I've found.

My goal is to get everything into a bash script and maybe spin up an Amazon instance that I can point that function to as well as some others that require manual updating. Using a cron job I can make it fairly automated.

znmeb commented 8 years ago

@bradleyfay It might be easier to make a Docker image than an Amazon instance. Then any time something changes you just push to GitHub and Docker Hub or Quay.io rebuilds automatically. And you can deploy anywhere there's a Docker host, including on a desktop.

bradleyfay commented 8 years ago

Interesting. Sounds very handy. I'll have to read up on that

bradleyfay commented 8 years ago

I updated a couple small bugs and made all the default pulls for the 2015 season.

I haven't added gameids for 2015 yet but these changes should help