search

bradmartin / nativescript-advanced-webview

NativeScript plugin for Chrome CustomTabs on Android and SafariViewController on iOS.
Other
60 stars 28 forks source link

remove fancy webview and use customtabs directly #37

Closed championswimmer closed 5 years ago

championswimmer commented 6 years ago

Signed-off-by: Arnav Gupta arnav@codingblocks.com

championswimmer commented 6 years ago

steps follow android documentation from here https://developer.chrome.com/multidevice/android/customtabs

bradmartin commented 6 years ago

hey @championswimmer - thanks for the PR - I'll need to look it over. Originally this plugin directly used CustomTabs but we opted for @triniwiz extension for some new behavior the Android CustomTabs did not have. If it's been added since then and we can drop @triniwiz custom extension then this would be great 👍 - I'll let Osei have a look when he can and make sure we aren't losing any of the "upgrades" that we went for with his lib. Thanks again 😄

championswimmer commented 6 years ago

With the faancywebview android library extension, setting toolbar color and hiding title aren't working. So either @triniwiz has to fix that then.

bradmartin commented 5 years ago

version 4.0.0 has fixed that issue and been updated.

Thanks again for this PR, hope everything is well for you :)