search

bradmontgomery / django-redis-metrics

Metrics for django apps backed by Redis.
http://django-redis-metrics.readthedocs.io
MIT License
93 stars 24 forks source link

reduce granularity? #34

Closed mvillarejo closed 10 years ago

mvillarejo commented 10 years ago

Hello,

Is there any way of reduce the granularity that you want for a metric? I know you increase the granularity from days to seconds but if that was flexible, that'll be brilliant, so let's say you could choose just up to seconds, hours, days, etc. depend of the type of metric you want to store.

Regards

bradmontgomery commented 10 years ago

Yeah, I think at the moment this should be a fairly high-priority ticket. Maybe a REDIS_METRICS_MIN_GRANULARITY setting? That infers that we may also want a REDIS_METRICS_MAX_GRANULARITY as well.

mvillarejo commented 10 years ago

that makes completely sense!

bradmontgomery commented 10 years ago

note to self: I'm labelling this as a bug, mostly because too-low a granularity without being able to change it seems like a bad idea.

bradmontgomery commented 10 years ago

Added this in v0.8.1, which I should push up to the the package index at some point tonight.

mvillarejo commented 10 years ago

Hello! yeah, it seems to work good, good job! I just had to modify granularity used: ['seconds', 'minutes', 'hourly', 'daily', 'weekly', 'monthly', 'yearly']

bradmontgomery commented 10 years ago

:trophy: Awesome! Thanks for the feedback :smile: