search

bradp / vv

:globe_with_meridians: Variable VVV - a VVV Site Creation Wizard.‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ :x: This project is no longer maintained. Please update your copy of VVV , which has most of the vv features built in.
GNU General Public License v2.0
1k stars 89 forks source link

Init bash script missing shebang and adding multiple empty lines #309

Closed franz-josef-kaiser closed 8 years ago

franz-josef-kaiser commented 8 years ago

The setup for the vv-init.sh script is missing a shebang, which probably should be #!/usr/bin/env bash. Also it is adding multiple empty lines, which could be avoided by checking if the variable is empty as "" seems to be the default for all of them:

[ -z "${VAR}" ] || echo "  $maybe_remove_defaults"

If there is the need to account for other defaults than ""/ empty, please see this ServerFault answer.

bradp commented 8 years ago

The shebang doesn't need to exist, as the file just gets sourced, not executed.

Thanks for the good advice on the empty lines, added in 4ff84ed6c753.