bradpauly / griddler-mailgun

Mailgun adapter for the griddler gem.
MIT License
17 stars 27 forks source link

Update README with example params submission #27

Open josh-works opened 5 years ago

josh-works commented 5 years ago

As outlined in https://github.com/bradpauly/griddler-mailgun/issues/19, griddler-mailgun will fail to parse params in some situations.

We can see the expected params here:

https://github.com/bradpauly/griddler-mailgun/blob/master/lib/griddler/mailgun/adapter.rb#L15

It can be tricky, because griddler-mailgun expects a key for To, but if it receives to, it will fail to grab the param.

I'm happy to make a PR that updates the behavior of griddler-mailgun, so it's case-insensitive. I didn't want to presume too much, so I thought a quick documentation update might save someone else down the road a few hours.

This PR is at odds with #28; if this PR is accepted, #28 should be closed, and vice versa.