bradshjg / flask-githubapp

Flask extension for rapid Github app development in Python, in the spirit of probot (https://probot.github.io/)
MIT License
56 stars 14 forks source link

No X-Hub-Signature header with GitHub Enterprise #12

Closed devlounge closed 4 years ago

devlounge commented 4 years ago

Hi,

I wanted to use your cool library, however it fais on _verify_webhook as the X-Hub-Signature header is not present in the payload.

What could we do to remediate this, I would not want to clone / modify the code, ideally

devlounge commented 4 years ago

Hi, sorry, I discovered that it is set only when the github app has a secret set, no issue then.

bradshjg commented 4 years ago

Glad you got it sorted, would it have helped if the docs made it clear that a secret was required?