search

bradtraversy / mern_shopping_list

Shopping List built with MERN and Redux
605 stars 436 forks source link

Upgraded Server to ES6 and Client to Typescript #34

Closed j-mcgregor closed 4 years ago

j-mcgregor commented 4 years ago

Hi Brad,

First off, can I say thank you for everything you've done - I've been watching your videos for a few years now and they've helped me enormously in my career. You're doing amazing work.

I've been learning Typescript and wanted a straightforward template to use going forward for smaller projects so thought I'd use this MERN project for reference.

In this PR I've converted the server to ES6 and the Client to Typescript (and moved a couple of things around, but apart from that its identical).

To run, however, you'll need an .env file with the following:

PORT=5000
MONGO_URI=blah
MONGO_DB_NAME=blah
JWT_SECRET=blah

Feel free to use it if you wish, just happy to give something back where and when I can

All the best,

Jack

HundredPercentCoverage commented 4 years ago

@bradtraversy - this PR merge should probably be reverted, as it causes the codebase to not match the video series, and anyone following the video series (on YT) that wants to skip ahead to the code is presented with something different with zero-to-minimal explanation for the differences.