Merging YT fixes for code smells - Githubissues

bradtraversy / proshop-v2

ProShop ecommerce website built with MERN & Redux Toolkit

532 stars 267 forks source link

Merging YT fixes for code smells #42

Closed ytrunina closed 3 months ago

ytrunina commented 3 months ago

ytrunina
- frontend/src/constants.js
  - Remove this commented out code.
- frontend/src/index.js
  - Remove this commented out code.
- frontend/src/screens/HomeScreen.jsx
  - '/Users/colbyco/Documents/GitHub/GroupProject/frontend/node_modules/react-router-dom/dist/index.js' imported multiple times.
    - (This will be named differently, but should be close enough)
  - Extract this nested ternary operation into an independent statement.
  - Unnecessary use of conditional expression for default assignment.
- frontend/src/screens/OrderScreen.jsx
  - Refactor this function to reduce its Cognitive Complexity from 30 to the 15 allowed.
  - Remove this commented out code.
  - Extract this nested ternary operation into an independent statement.
  - Do not use Array index in keys
  - Prefer using an optional chain expression instead, as it's more concise and easier to read.

ytrunina commented 3 months ago

Merging YT fixes for code smells