search

bradvin / social-share-urls

Social Share URLs
BSD 3-Clause "New" or "Revised" License
2.78k stars 304 forks source link

updated xing share data #631

Closed hawc closed 5 years ago

HoldOffHunger commented 5 years ago

Hey hey, thanks for getting involved and checking this out.

The URL change looks good! I fully approve.

But -- I'm not sure why there was a deletion of links, extended documentation, and the like? This seems unrelated to the overall change request, so, I will fix the URL myself. But, I want to reject unnecessary deleting of useful links and reference sources.

(Yes, many of our sources are "unofficial," but the URL's for them work, and everyone uses them. Better to have an unofficial, documented source than no source at all.)

HoldOffHunger commented 5 years ago

Changes as requested above, minus the deleting of documentation, have been added! Thanks again!

Going to close for now, please open a new ticket if you feel necessary.

hawc commented 5 years ago

I removed the unofficial documentations because there's now an official one. Don't really see a point in keeping the unofficial ones. But yeah, both is fine 😄