search

bradymholt / cron-expression-descriptor

A .NET library that converts cron expressions into human readable descriptions.
https://bradymholt.github.io/cron-expression-descriptor/
MIT License
1.01k stars 188 forks source link

Q: "Incorrect" translation ids used? #154

Closed Salamek closed 2 years ago

Salamek commented 2 years ago

Hi, just wanted to ask if this is by design or copy/pasta error?:

GetSecondsDescription 7th parameter uses ComaMinX0ThroughMinX1 (?Min => Seconds?) https://github.com/bradymholt/cron-expression-descriptor/blob/9c639aecca8483cec2cee60bef9fe5d3867c74c0/lib/ExpressionDescriptor.cs#L289

GetMinutesDescription 7th parameter uses ComaMinX0ThroughMinX1 (?OK?) https://github.com/bradymholt/cron-expression-descriptor/blob/9c639aecca8483cec2cee60bef9fe5d3867c74c0/lib/ExpressionDescriptor.cs#L324

GetHoursDescription 7th parameter uses ComaMinX0ThroughMinX1 (?Min => Hours?) https://github.com/bradymholt/cron-expression-descriptor/blob/9c639aecca8483cec2cee60bef9fe5d3867c74c0/lib/ExpressionDescriptor.cs#L343

GetMonthDescription 7th parameter uses ComaMonthX0ThroughMonthX1 (OK) https://github.com/bradymholt/cron-expression-descriptor/blob/9c639aecca8483cec2cee60bef9fe5d3867c74c0/lib/ExpressionDescriptor.cs#L443

GetYearDescription 7th parameter uses ComaYearX0ThroughYearX1 (OK) https://github.com/bradymholt/cron-expression-descriptor/blob/9c639aecca8483cec2cee60bef9fe5d3867c74c0/lib/ExpressionDescriptor.cs#L513

Just wanted to ask before i refactor my code...

bradymholt commented 2 years ago

Yes, these are intentional.