bradyrx / esmtools

:octopus: a toolbox for Earth System Model analysis :octopus:

https://esmtools.readthedocs.io/en/latest/

MIT License

27 stars 4 forks source link

Secure #107

Closed aaronspring closed 3 years ago

aaronspring commented 3 years ago

Description

See xskillscore issue, same as in climpred Should be done for every branch

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@20c005d). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #107   +/-   ##
=========================================
  Coverage          ?   76.60%           
=========================================
  Files             ?       27           
  Lines             ?     1419           
  Branches          ?        0           
=========================================
  Hits              ?     1087           
  Misses            ?      332           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20c005d...332c20b. Read the comment docs.

aaronspring commented 3 years ago

Tests fail bc numba import issue. Anderson fixed this in his climpred PR

bradyrx commented 3 years ago

@aaronspring , will this break the github actions? I had those in there to make sure they ran on the PR branch being added and not the master branch. I can see why it could be a security concern but this might break our CI system.

bradyrx commented 3 years ago

For instance, the numba fix probably isn't reflected here in this testing since those other lines were deleted from the CI

aaronspring commented 3 years ago

@aaronspring , will this break the github actions? I had those in there to make sure they ran on the PR branch being added and not the master branch. I can see why it could be a security concern but this might break our CI system.

I looked into other projects. they setup CI similarly as we did but without the secrets. I think it might only break CI seen in the forked repo. CI in the main repo will still work.

aaronspring commented 3 years ago

For instance, the numba fix probably isn't reflected here in this testing since those other lines were deleted from the CI

the good news is that py38 passes. so it is a versioning thing. in climpred adding the numba dev branch worked.

aaronspring commented 3 years ago

also you need to delete or fix old branches that have this secrets lines