corr/autocorr tests breaking at climpred

bradyrx / esmtools

:octopus: a toolbox for Earth System Model analysis :octopus:

https://esmtools.readthedocs.io/en/latest/

MIT License

27 stars 4 forks source link

corr/autocorr tests breaking at climpred #79

Closed bradyrx closed 4 years ago

bradyrx commented 4 years ago

See https://github.com/bradyrx/climpred/issues/262. This will be migrated over here.

aaronspring commented 4 years ago

next xr will have corr and cov. but those wont have the lag keyword so lets keep our implementation

bradyrx commented 4 years ago

Effectively closed by https://github.com/bradyrx/esmtools/pull/88. I got rid of autocorr since you can just run corr(x, x) and renamed ACF to autocorr to match the pandas language for this. I think the errors were due to different handling of p values, whether that was effective p value or not.