search

bradyt / dart-server

An Emacs minor mode for the Dart server
GNU General Public License v3.0
0 stars 0 forks source link

Fix issues brought up in melpa pull request #7

Open bradyt opened 5 years ago

bradyt commented 5 years ago

Especially at https://github.com/melpa/melpa/pull/6352#issuecomment-520111304. (EDIT: Issues at that particular comment are all addressed except for that regarding special-mode, which is opened as new issue at https://github.com/bradyt/dart-server/issues/8.)

This is a note to either fix these issues, or file each unresolved issue to the issue tracker here, or even add as failing tests in the testing framework.

bradyt commented 5 years ago

New comments from https://github.com/melpa/melpa/pull/6352#issuecomment-522203159:

  • Consider splitting out dart-flycheck as a separate package. This would make the packaging more coherent, and pave the way for flymake support etc. later. Doing this will generally help the modularity of the code.
  • pcase is nice in cases like this
  • Here you've got a when-let containing a clause that should also be - but isn't - a when-let.
  • You can canonicalise paths using file-truename, e.g. here
  • If possible, make dart-server-expand work as a completion-at-point function. (See completion-at-point-functions.) Binding M-/ to an ad-hoc completion mechanism really isn't ideal!