bradyt
commented
2 years ago Thank you for the bug report.
I had a vague sense I'd made some things worse, as I allude to at https://github.com/bradyt/taskw-dart/issues/5#issuecomment-990143873, with:
Also I think anything like
a:bwill be silently dropped.
I appreciate you providing a usecase that gives me a better sense of how severe this is, and better motivation.
I've drafted a solution, where in my use of PetitParser, I will make an earlier check that the colon is being used in a known attribute, for example pri:H. This way, Blog: Test will be parsed as you expect, as description: 'Blog: Test'.
In that same comment I linked, I also mention I don't like my first attempt at quote parsing, and I plan to remove that feature. That would actually allow an empty description to pass through, so I think this is a good time to lift the field validation I have in other parts of the UI, to the Task constructor. Then, during task creation, it should show a more readable exception to the user, whether they enter an empty string, or an implicitly empty description like the following:
taskParser('+foo') // ==> Task(description: '', tags: ['foo'])So I think I have a reasonable plan in place, some unit tests are already modified. I hope to soon work on testing these in the app and deploying.
EDIT: I misspoke. I think the UI code was already setup to have empty descriptions validated, as I think you'll see if you try to add a task simply as +foo. But lifting the validator from UI into the Task constructor should make it easier for developer to reason about, or test. The parser was erroring before the Task field validators were checked, and even if I remove the quote parsing, the parser still doesn't present a great error message in the case of the empty string, so I will probably add a special case for empty strings, so the Task constructor can be relied on for now with better error messages. In other words, taskParser will short circuit on the empty string, like taskParser('') ==> Task(description: ''), and the Task constructor will call validators which will throw an exception.
danielquinn
In trying to create a few tasks last night, I discovered two oddities I thought worth reporting.
In the first case, I tried to create a task to write a new blog post. I called it
Blog: Testand hit the little "enter" icon on the far right of the dialogue.The resulting task however wasn't called
Blog: Test, but just plainTest. I managed to reproduce this with a variety of different permutations, but strangely,X: Testcame out as it should.Secondly, I sleepily tried to create an empty task.
That is, I opened the create task dialogue like before, but instead of typing anything, I just hit that "enter" icon again. The result was a hefty stack trace:
Neither of these are a big deal obviously and they're easy enough to work around, but I thought you'd wanna know about them :-)