Closed GaryJones closed 1 year ago
This gist processor may even be better being pulled out into a new class?
Something to consider is how changes to the HTML structure will affect the way the plugin works. Right now it's reliant on the current markup, so if there's a way we can break the processor out and make it easy to update in the event the markup does change, that would be ideal. We may also want to modify the default class names to move away from the .pre-
suffix.
The
process_gist_html()
method currently does too much.It:
That is far too much responsibility for a single method, and should be split into several smaller protected methods that would be more easily testable and easier to read and maintain.