bradyvercher / gistpress

WordPress plugin to add Gist oEmbed and shortcode support with caching.
GNU General Public License v2.0
143 stars 28 forks source link

Re-work of the logging / debug bar panel feature, and other small changes. #4

Closed GaryJones closed 11 years ago

GaryJones commented 11 years ago

Re-work of the logging / debug bar panel feature:

Other changes:

bradyvercher commented 11 years ago

Nice! I like what you've done overall and will spend some time checking out the standards you mention. I do have a couple questions just to seek clarification for my benefit and will leave a some comments in the commit.

GaryJones commented 11 years ago

Ah, if 1.1.0 isn't out, then no need for my version bump.

For each of the points you highlight that need a change, I'll do further commits to my branch (and therefore this PR), before you commit.

bradyvercher commented 11 years ago

I think those were the main things I had questions about. There may be a couple of additional formatting things I noticed on first glance, but have to read back through and can take care of them.

I think the ksort() in the shortcode hash method can be moved to the main shortcode method just after the attributes are sanitized. And maybe save the hash to a local variable in methods where it's being used quite a bit instead of repeatedly calling the method, but that's stuff I can take care of.

This isn't in the plugin repository because I mainly built it for use on our site, but I'm not opposed to renaming it and submitting with you as a contributor if you're interested.

GaryJones commented 11 years ago

I think those commits should take care of the queries you raised.

I'm not fussed about it going into the plugin repo - I've been thinking of pulling my existing ones out of there anyway and just having them on Github / my own repo - but if you want to push to the WP repo I have no objections about being listed as a contributor.