search

bradyvercher / gistpress

WordPress plugin to add Gist oEmbed and shortcode support with caching.
GNU General Public License v2.0
143 stars 28 forks source link

Style sheet URL is broken #42

Closed GaryJones closed 10 years ago

GaryJones commented 10 years ago

GitHub is now including the full URL to the style sheet in their JSON response, so the resolved URL is https://gist.github.comhttp://gist.github.com... which breaks the appearance of gists.

GaryJones commented 10 years ago

If I'm reading it right, a user can update any post containing a gist, and that will trigger the cache to be cleared for that post, and it should end with the global style sheet option being updated with the new value.

@bradyvercher - I created a hotfix/2.0.3 branch so this could be released without including the new bookmark URL feature. Once tagged, it will need to be merged into master (as latest stable release) and into develop (for ongoing work). "Tested up to" could also be updated.

carldanley commented 10 years ago

I too have experienced the same breakage. When can we get this into the plugin? It's breaking my site at the moment.

carldanley commented 10 years ago

Also - FWIW, @GaryJones's patch does resolve the broken stylesheet URL. :+1:

bradyvercher commented 10 years ago

Patch worked for me, too, so I pushed this as 2.0.3. Thanks for the fix @GaryJones!