search

bradyvercher / gistpress

WordPress plugin to add Gist oEmbed and shortcode support with caching.
GNU General Public License v2.0
143 stars 28 forks source link

Selecting lines not working with WP 4.5.2 #66

Closed marcelstoer closed 8 years ago

marcelstoer commented 8 years ago

Expected Behavior

[gist id="bb88f9d4c3436b0d311416ada53c13a7" file="file-validate-email.php" lines="34-44"] should display lines 34-44.

Current Behavior

There's just a link to the Gist by ID: https://gist.github.com/bb88f9d4c3436b0d311416ada53c13a7

Steps to Reproduce (for bugs)

  1. Use WP 4.5.2.
  2. Install latest GistPress release or latest from the develop branch.
  3. Use gist short code as above.

    Your Environment

GistPress installed on my server at http://frightanic.com/blog/wp-content/plugins/gistpress/README.md.

bradyvercher commented 8 years ago

Hi @marcelstoer, as I mentioned in #67, it looks like the issue here is that the value in the file attribute is incorrect. Can you update that and let me know if everything works correctly?

GaryJones commented 8 years ago

@marcelstoer Any feedback?

marcelstoer commented 8 years ago

That was indeed the problem, thanks. Sorry for not responding earlier.