Check how gists look on AMP pages

bradyvercher / gistpress

WordPress plugin to add Gist oEmbed and shortcode support with caching.

GNU General Public License v2.0

143 stars 28 forks source link

Check how gists look on AMP pages #69

Closed GaryJones closed 1 year ago

GaryJones commented 8 years ago

AMP pages use a limited set of HTML elements, and strip everything else out.

Expected Behaviour

Ideally, if the gist can't be displayed correctly, we'd just leave a clear link to the exact gist ID, file and line number as needed.

Current Behavior

No idea - but it should be tested.

Possible Solution

I'm really not even sure how we'd test if the current page is being shown in an AMP context.

GaryJones commented 8 years ago

https://github.com/Automattic/amp-wp#handling-media

Looks like there might be some custom embed handler we could use, that would allow at least something to be displayed, instead of it getting stripped out completely.

anythinggraphic commented 8 years ago

Awesome!!

GaryJones commented 5 years ago

There is now an amp-gist component.