bradyvercher / gistpress

WordPress plugin to add Gist oEmbed and shortcode support with caching.
GNU General Public License v2.0
143 stars 28 forks source link

Gist Shows Without Tabs #74

Closed joshuadavidnelson closed 7 years ago

joshuadavidnelson commented 7 years ago

For some time now my embedded gists have shown up without the lines tabbed (so everything is left-aligned). I haven't modified any styling on my theme, but I have kept the plugin updated (currently at version 3.0.0).

You can view an example here versus in GitHub here.

bradyvercher commented 7 years ago

It looks like tab characters are being converted to spaces somewhere along the way. Do you have some code or a plugin that might be doing that? You'll likely need to update the post after deactivating any plugins to flush the cache.

joshuadavidnelson commented 7 years ago

Hmmm... I shouldn't, but I'm guessing this is just me seeing this error. I'll dig into it later this evening on my local environment to see if there's a plugin conflict. Thanks!

GaryJones commented 7 years ago

CSS all looks fine - white-space:pre coming from Github's CSS etc.

joshuadavidnelson commented 7 years ago

Weird - must be something on my setup conflicting with it. Thanks for the quick responses, guys - sorry if I wasted your time. I'll circle back if I find a bug/conflict.

GaryJones commented 7 years ago

@joshuadavidnelson Looking at the view-source: for your page, shows that your HTML is being minified. Maybe try turning this off temporarily, or adding an exclusion for the div.gist element.

joshuadavidnelson commented 7 years ago

Thanks for the tip. I'm using WP Rocket. I turned off minification, bumped the gist shortcode, cleared the cache, opened incognito. Still see it. I'm guessing it's something on my end, though, not a bug with the plugin at this point. Thanks for the assistance!

wpsmithtwc commented 6 years ago

I did some testing and this is most likely due to HTML minification (or at least it was for me).