camera intrinsics calculation

bradyz / cross_view_transformers

Cross-view Transformers for real-time Map-view Semantic Segmentation (CVPR 2022 Oral)

MIT License

531 stars 81 forks source link

camera intrinsics calculation #9

Closed melights closed 2 years ago

melights commented 2 years ago

Hey Brady, thanks for the great work and the open-sourced code!

I found the calculation of rescaled intrinsics is a bit wired here:

https://github.com/bradyz/cross_view_transformers/blob/8d1d688711c3d7a85004f86da3f0874c38619489/cross_view_transformer/data/transforms.py#L135

Shouldn't the scaling factor be w_resize and h_resize instead of w and h?

bradyz commented 2 years ago

Nice catch! I don't know how long this bug was in here but I'll patch this in this week along with some of the other issues. Thanks for your careful eye