Support for boolean values in consumer_config

braedon / prometheus-kafka-consumer-group-exporter

Prometheus Kafka Consumer Group Exporter

MIT License

73 stars 39 forks source link

Support for boolean values in consumer_config #37

Closed j1king closed 4 years ago

j1king commented 4 years ago

Recently, I had to add a parameter(ssl.check.hosthostname) with boolean value to the consumer.properties and realized that I can't add boolean value without editing the code. So I added a support for it. :)

Sample consumer.properties

security.protocol=SSL
ssl.certfile=/path/to/my_cert.pem
ssl.keyfile=/path/to/my_key.pem
ssl.check.hostname=false

braedon commented 4 years ago

Hi @JaewonKim, thanks for the PR! That was a bit of an oversight on my part when I added config file support.

I've had a quick dig into this, and it seems like there's a similar issue for numeric and list type settings as well... I'll try and get this change, and support for the other types, out in the next few days.

braedon commented 4 years ago

Released in 0.5.5