Esc doesn't work if focus is in the language search entry

bragefuglseth / keypunch

Practice your typing skills

GNU General Public License v3.0

85 stars 13 forks source link

Esc doesn't work if focus is in the language search entry #35

Closed UrtsiSantsi closed 3 weeks ago

UrtsiSantsi commented 3 weeks ago

Esc doesn't work if focus is in the language search entry in the text language dialog.

Steps to reproduce the behavior:

Press Ctrl+,
The "Text language" dialog is opened and the focus is in the search entry
Press Esc

Expected behavior The dialog should close, but it stays open. Can also be reproduced if the dialog is opened from the menu and the search entry selected.

[ x] I confirm that I can reproduce the bug in the Flathub version of the app.

bragefuglseth commented 3 weeks ago

Good catch! Apparently GtkSearchEntry overrides the escape key and emits its own stop-search signal when it's clicked. Keypunch will have to connect to that and close the dialog manually when that happens.