search

bragma / winston-azure-application-insights

Azure Application Insights transport for Winston
MIT License
16 stars 26 forks source link

tracking exception tracks twice #2

Closed jeffmcaffer closed 7 years ago

jeffmcaffer commented 7 years ago

Should there be a "return" on #L124? I'm seeing if errors as exceptions is on then we'll get a trackException (good) but then execution will continue and do a trackTrace (seems bad).

bragma commented 7 years ago

Yes it seems wrong to me too, it needs to return and call callback. I'll give it a look

bragma commented 7 years ago

@jeffmcaffer can you please clone from devel branch and check if the issue is correctly fixed. It seems ok to me. Thanks!

jeffmcaffer commented 7 years ago

sorry for the delay. yeah, that cange looks good. Thanks. Ship it!

bragma commented 7 years ago

Sorry for the late reply, I've merged all PRs in 1.1.1