search

brahimdidi / Todolist-App

In this project I will create a simple app that allows users to input and remove what hey plan to do.
3 stars 0 forks source link

Best Practices Peer Review #9

Open ahangarha opened 2 years ago

ahangarha commented 2 years ago

I have noticed some cases of not following best practices in JS. In most of the cases you have chosen good names which are both meaningful and also nicely written in camleCase. Yet in some cases variable names are not following the best practices:

https://github.com/brahimdidi/Todolist-App/blob/bebd482276901748dc0071a8652da2041f3ae123/src/index.js#L7 https://github.com/brahimdidi/Todolist-App/blob/bebd482276901748dc0071a8652da2041f3ae123/src/AddandRemove.js#L116

I think it would be better to use something like todoText or todoTitle or todoDescription. What do you think?

I also noticed edit method having typo in its name: https://github.com/brahimdidi/Todolist-App/blob/bebd482276901748dc0071a8652da2041f3ae123/src/AddandRemove.js#L39

Also here, I think something like todo would be more descriptive than obj: https://github.com/brahimdidi/Todolist-App/blob/bebd482276901748dc0071a8652da2041f3ae123/src/AddandRemove.js#L35

Also I noticed file name for AddandRemove doesn't follow the convention. I couldn't guess why. May you share if you had anything particular in mind?

brahimdidi commented 2 years ago

thanks for your review I will check that