search

brahmlower / ansible-factorio

A role for creating Factorio servers
https://galaxy.ansible.com/bplower/factorio/
4 stars 6 forks source link

use include_tasks instead of include #12

Closed jabertwo closed 8 months ago

jabertwo commented 8 months ago

Since release 2023-05-16 include is no longer supported, instead include_tasks or import_tasks should be used. This now works with the current ansible_core release.

brahmlower commented 8 months ago

Hey @jabertwo 👋 Thanks for opening the PR, and sorry for my delay here 😱 I've been meaning to check this out all week but just kept forgetting (work's been a bit nuts lately and has been consuming all my focus)

This looks good to me, though I think the min_ansible_version for the playbook will need to be updated too. I've not kept up with changes to the ansible ecosystem in several years so I'm struggling to find which version of ansible first introduced include_tasks. I found references to it in the 2.10 docs but couldn't find docs for any earlier versions, so maybe 2.10 is just the earliest supported version at this point?

I guess let's roll with 2.10 as the minimum version, and if that breaks stuff for someone then we'll just cross that bridge when we get there 😅 Can you include that change in this PR?

jabertwo commented 8 months ago

Hey @brahmlower, I have changed min_ansible_version to 2.10, since I didn't find anythin else aswell.