braice / MuMuDVB

A DVB IPTV streaming software
http://mumudvb.braice.net/
GNU General Public License v2.0
219 stars 133 forks source link

Include Application Signalling (HbbTV) PIDs #267

Closed freddy36 closed 3 years ago

freddy36 commented 3 years ago

HbbTV data is sent in a extra stream (dedicated PID). To make it work we have to include the PID signalled via the PMT stream_type 0x05 (ITU-T Rec. H.222.0 | ISO/IEC 13818-1 private_sections) entry with application_signalling_descriptor set.

freddy36 commented 3 years ago

Made the changes to the comment/log message. Which doc do you thing needs to be updated? Changelog seems to be completely outdated and the README doesn't mention this PID filtering mechanism at all.

braice commented 3 years ago

Sorry for the late reply,

The doc to be update is the README_CONF

I was compiling the asciidoc before and it was getting out of date, now you can see the blow directly at github (and the website points to it), so despite the formatting issues at least it is up to date https://github.com/braice/MuMuDVB/blob/mumudvb2/doc/README_CONF.asciidoc

On Wed, Jan 20, 2021 at 12:07 PM Frederik Kriewitz notifications@github.com wrote:

Made the changes to the comment/log message. Which doc do you thing needs to be updated? Changelog seems to be completely outdated and the README doesn't mention this PID filtering mechanism at all.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/braice/MuMuDVB/pull/267#issuecomment-763527646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRID2T3R6HRFYSE5T3NS3S222PFANCNFSM4VVLOAAQ .

freddy36 commented 3 years ago

What part of the documentation do you want me to update? The existing pid filtering details for autoconfiguration seems to be completely undocumented. Why are certain PIDs droped at all in the current design? Did they cause problems with some end devices?

braice commented 3 years ago

Sorry I was confused, the patch is OK I am merging