Closed trollcop closed 2 years ago
Hello
That look fine to me ! any hesitation before I merge ?
Brice
On Fri, May 27, 2022 at 10:18 AM dongie @.***> wrote:
For users of mumudvb in Japan, which does not follow the EN 300 468 character set encodings (and does not use UTF-8) I added an option to convert SI/EPG strings by using libaribb24. This is automatically detected but can be controlled by --enable-arib-support or --disable-arib-support option. Once built in, it is required to use -j or --japan to further enable this conversion. There is no simple way to auto-detect Japan-specific TS so it is better to allow user to specify this option by command line. This is similar to how tsDuck etc does it.
With proper conversion, Japanese ISDB streams look correct in channel list and during debug output:
Info: Autoconf: Diffusion 3 channels
Info: Autoconf: Channel number : 0, service id 56360 name : "TVQ九州放送1"
Info: Autoconf: Multicast4 ip : :0
Info: Autoconf: Unicast : Channel accessible via the master connection, 0.0.0.0:4242
Info: Autoconf: Channel number : 1, service id 56361 name : "TVQ九州放送2"
Info: Autoconf: Multicast4 ip : :0
Info: Autoconf: Unicast : Channel accessible via the master connection, 0.0.0.0:4242
Info: Autoconf: Channel number : 2, service id 56744 name : "TVQ九州放送携帯"
Info: Autoconf: Multicast4 ip : :0
Info: Autoconf: Unicast : Channel accessible via the master connection, 0.0.0.0:4242
[image: image] https://user-images.githubusercontent.com/4640472/170658296-0c61e56a-0cdd-4478-bd8e-8ff21cbc2339.png
I've also implemented --disable-dvb-support to allow building without any DVB-API support, even on systems with kernel headers. This allows using mumudvb strictly as UDP/Multicast input.
If someone could test building this and see if it works, that would be great. Some example ISDB-T streams are here: https://tsduck.io/streams/?name=japan-dttv
You can view, comment on, or merge this pull request online at:
https://github.com/braice/MuMuDVB/pull/298 Commit Summary
- b0a18cc https://github.com/braice/MuMuDVB/pull/298/commits/b0a18cce704eb915675788ae614ee8396317801f Add support for libaribb24 to configure.ac
- ab56fcd https://github.com/braice/MuMuDVB/pull/298/commits/ab56fcd97dce04afd4685a08f48ed8bcf36a967f Add: Optional ARIB STD-B24 character set support
- 530d362 https://github.com/braice/MuMuDVB/pull/298/commits/530d3623e72d2c76ed7b091ff8791e1f59eb68dd Remove forgotten debug output
- dd04f68 https://github.com/braice/MuMuDVB/pull/298/commits/dd04f68e82c6febe2e2a122ce8efc6ace77373bb Disable ARIB support on windows for the time being
File Changes
(8 files https://github.com/braice/MuMuDVB/pull/298/files)
- M configure.ac https://github.com/braice/MuMuDVB/pull/298/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810 (71)
- M doc/README.asciidoc https://github.com/braice/MuMuDVB/pull/298/files#diff-a11d422ccb580e18dd01e38ef47af65ceded8d2b3e78cf1fedf7522a76b2e2ee (9)
- M src/config_win32.h https://github.com/braice/MuMuDVB/pull/298/files#diff-0d63f23aaf8c947f1fa0f279636833304728a2b94ac278568aa7af8da715f88e (3)
- M src/log.c https://github.com/braice/MuMuDVB/pull/298/files#diff-46b881d73b3e6407e73cdcc59cdaf1de4bb5a0122acf867cb88bdd28ca34ca45 (70)
- M src/log.h https://github.com/braice/MuMuDVB/pull/298/files#diff-67a354ecb35f341abf57f84bd0d714b05280fddb1063b90a31f0d3ef67675bd7 (3)
- M src/mumudvb.c https://github.com/braice/MuMuDVB/pull/298/files#diff-82b2d700bfd4539dd6a4fbb54c8e6b8e4674b05753bc484d85e39fb71c59e3f8 (7)
- M src/mumudvb.h https://github.com/braice/MuMuDVB/pull/298/files#diff-b4ef498f189e814231a15eb651eb8df0c84493dc0e99503ae554276dffa60834 (3)
- M src/mumudvb_mon.c https://github.com/braice/MuMuDVB/pull/298/files#diff-4a64bf103fb945b5b6fa2ef6410de54be48ad8ac7ef6e0d9462999862116f52f (15)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/braice/MuMuDVB/pull/298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRIDZEVAPVXG3G2PST6RDVMCAOVANCNFSM5XDPWIAA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
It works for me, and I've tried building it in a few of my test environments and it seems to work, so probably OK?
Addition of --disable-dvb-support is handy for building on embedded systems where DVB-API might not be available, so its a win even if B24 stuff is not used (it's autodetected and doesn't need to be part of install)
So I think it's OK to merge.
Let's give it a try !
For users of mumudvb in Japan, which does not follow the EN 300 468 character set encodings (and does not use UTF-8) I added an option to convert SI/EPG strings by using
libaribb24
. This is automatically detected but can be controlled by--enable-arib-support
or--disable-arib-support
configure option. Once built in, it is required to use-j
or--japan
to further enable this conversion. There is no simple way to auto-detect Japan-specific TS so it is better to allow user to specify this option by command line. This is similar to howtsDuck
etc does it.With proper conversion, Japanese ISDB streams look correct in channel list and during debug output:
I've also implemented
--disable-dvb-support
to allow building without any DVB-API support, even on systems with kernel headers. This allows using mumudvb strictly as UDP/Multicast input.If someone could test building this and see if it works, that would be great. Some example ISDB-T streams are here: https://tsduck.io/streams/?name=japan-dttv