search

braid-org / braid-spec

Working area for Braid extensions to HTTP
https://braid.org
233 stars 16 forks source link

Get requests with 'version' header should all appear in same section. #109

Closed blottn closed 1 year ago

blottn commented 3 years ago

The heading "If a GET request contains a Version header" implies that all further headings would have no version header.

toomim commented 3 years ago

Hi, I'm not sure what you mean. Can you be more explicit? By "Section", do you mean "Section 2.4"? Or are you just referring to the 10 lines from 375-385, or some other range of lines? Which requests do you think should appear in the section?

blottn commented 3 years ago

Hey, sorry for the poor explanation! I meant, within section 2.4, there are 2 headings, one regarding requests with Version headers and one regarding requests with Parents headers. The former implies that latter headings do not contain any requests with Version headers. However the point regarding requests with both parents and versions appears in the second.

Im suggesting that maybe this needs to be moved into the first heading or create a third heading "If a GET request contains both a Parents and a Version header"

toomim commented 1 year ago

Thank you! Updated in https://github.com/braid-org/braid-spec/pull/113/commits/1889b9fd6548dad60b10be687e1522ab1b9bb94c.