search

braid-org / braid-spec

Working area for Braid extensions to HTTP
https://braid.org
233 stars 16 forks source link

Clarify that the parser is responsible for parsing the patch #12

Closed mitar closed 4 years ago

mitar commented 4 years ago

It seems = has special meaning? Can selector contain such string?

toomim commented 4 years ago

Yes. But we should clarify that in the spec. This should be totally parseable:

["="] = 3

In practice, the Parser (aka selector) implementation will be responsible for parsing a braid-patch. It'll have to make sure that the grammar it defines for indexing is unambiguous.

mitar commented 4 years ago

Not sure what is your policy about closing issues, but shouldn't they be closed once things are merged in, or decided that they will not be done? Above you mention that you agree this should be clarified, but then closed the issue? So should it be clarified or not?

Hm, every parser will have to parse the whole patch? That is an interesting design decision.

toomim commented 4 years ago

Oh, I closed it because the subject of this issue is a question, which was answered.

But sure, let's change the subject to "Clarify that the parser is responsible for parsing the patch."

mitar commented 4 years ago

From #13, we should also clarify that parser also has to define how portals are to be specified for that parser type.

mitar commented 4 years ago

This is not applicable anymore because now everything is parsed through the HTTP stack itself.