Closed puja-trivedi closed 9 months ago
so from the 4 rows that you mentioned, I believe 3 were in the green table:
tissue sample
in Receive Sample
tabSeqCore library pool tube barcode
in Delivery Library Pool
tablibrary pool label
is library pool name
from Delivery Library Pool
tabBut I agree that I couldn't find enriched cell sample container name
(and Dissociated cell oligo tag name
) in the comparison I was doing last week
Listing all the comments that I have, we should check with @patrick-lloyd-ray and Pam:
LinkML Slot or Attribute Name
from yesterday discussion it seems like it might be better to keep the unit as a part of the name, so perhaps in these row we should have
amplified quantity ng
concentration nm
concentration pM
concentration pM
volume ul
PhiX spike percent
I noticed that in several places (e.g. row 9 and 14) you use cohort
instead of set
or study sets
, we should confirm that this is really ok
you have date
in row 6, 24, 34 - I think we should use more specific terms like creation date
or embargo date
perhaps in 17 we should have oligo tag name
?
there is something wrong in row 35, since you use name
for SeqCore library pool tube barcode
I'm not sure if you should be using xref
in row. 33 and 36, perhaps it should be name
?
in row 37 I would keep "tube" in the slot name, so tube avg size bp
in_subset
should we use analysis
, tracking
or required for analysis
, required for tracking
?
in_subset data is missing for 4 rows (not in green table so I didn't know how to fill it out): tissue sample, enriched cell sample container name, SeqCore library pool tube barcode, library pool label.
@djarecka can you please review the columns I filled out.