search

brain-bican / metadata-schemas

A repository for BICAN metadata schemas and their development.
4 stars 3 forks source link

linkml updates #34

Closed djarecka closed 10 months ago

djarecka commented 10 months ago

@patrick-lloyd-ray - I've updated the linkml slots names from #33 based on our conversation and my commends in #33, and I fixed the in_subset column

I will update the unit and vmin/max, will just wait for @rightbower so she has a chance to update #32

@patrick-lloyd-ray - I could update is_required/nullable column, but should I just do it based on the latest/Kim Green Table version?

patrick-lloyd-ray commented 10 months ago

Yes, updating is_required/nullable based on that version is fine with me.

djarecka commented 10 months ago

@patrick-lloyd-ray: updated the column, but I also changed the name of the column just to "Nullable" (since it is the opposition to is_required).

There are still 2 fields, i.e. dissociated cell oligo tag name and enriched cell sample container name, that I couldn't find in the green table, so left the values True (and for now ? in the Subsets column)

patrick-lloyd-ray commented 10 months ago

LGTM. Thank you!