Closed patrick-lloyd-ray closed 1 month ago
just realized that this is marked as Draft
, so perhaps I reviewed it too quickly… Anyway, I will keep my comments, and happy to review again
I'm going to create another PR for the value sets (the exclusive_categorical values).
@patrick-lloyd-ray - I've noticed that there are some extra columns at the end, including repetition of Min Value
and Max Value
I haven't finished my google sheets scripts, but I used the draft version to tests these metadata, and the difference I found was in the definition of post_mortem_interval
comparing to other metadata (I think I suggested adding "of", and it is just missing in the other files, I can submit PR later, when I check everything)
Thanks! I fixed the column duplicates.
Opening a new PR for the minor grammatical change is a good plan.
Will close #46 when complete.