Closed djarecka closed 2 months ago
@satra @lydiang @patrick-lloyd-ray - if you have time this week you can give me some feedbacks, especially on the issues listed in the PR description. If not we will discuss it later
notes from the discussion with Pam at the SFN:
@djarecka could you check the integer data types here: https://github.com/brain-bican/metadata-schemas/pull/31 and make sure we are accurate?
@patrick-lloyd-ray - yes I'm planning to check it, I forgot that this is in PR and that's probably better place to add more comments
@patrick-lloyd-ray - yes I'm planning to check it, I forgot that this is in PR and that's probably better place to add more comments
Great! Feel free to simply suggest changes directly on the PR.
I've modified the converter from #19 to work for the examples of the Green Table (for now I only updated
cvs2yaml
.I've added also an example of cvs files and the header that could be used to run it:
python utils/csv2yaml.py --csv csv_test/GreenTable.csv --enum csv_test/GreenTable_ValueSet.csv --header csv_test/head.yaml --output csv_test/gt_test.yaml
The output should look like
csv_test/GreenTable_model.yaml
I've slightly modified the GreenTable format, see here (note that I only worked on
Generate Library
for now). The changes are related to the Value Sets and I've created a new tab:Generate Library Value Sets
(you can compare withValue Sets Orig
). The original tab for Value Sets was hard to automatically convert to pandas.DF, so I've added columnField Name
to remove the titles of previous multiple columns. In order to properly link ValueSets from theGenerate Library
to the values for specificField Name
, I assumed that it is either the originalField Name
from theGenerate Library
tab orDataType
has the name of the set values, e.g.ValueSet: barcode name
.Issues with Value Set that need feedback:
Code
andCode general
columns, should this be added to the model?Other Info
, not sure what to do with itR1/R2 index name
, so for now I removed itOther issues to discuss:
Identifier/Metadata
column. I assumed that the additional parent class will have the nameEnriched cell source barcode name
do not match the value setsOther TODOs (that do not require feedback):
FYI. I will look into the code from the Yale team, I only opened the output quickly and I noticed that there are some things that we discussed done differently, so I decided to finish this PR to help with the discussion.