search

brain-child / moobo

Visualize your ideas on moodboards
GNU General Public License v3.0
22 stars 4 forks source link

[Enhancement] Show placeholder 'image' icon #8

Closed kdwk closed 2 years ago

kdwk commented 2 years ago

When the user double clicks to add an image, the location where they double click should have an 'image' icon as a placeholder so the user knows where the image will be added

pthrrr commented 2 years ago

I like that idea. Thank you!

pthrrr commented 2 years ago

@kdwk how about this?

https://user-images.githubusercontent.com/29637548/142029499-4040daf9-f7be-47d6-b4b6-e263b1e7cb97.mp4

kdwk commented 2 years ago

@pierrefabarius I’m not sure about this. elementary OS uses this icon to mean ‘unavailable’. They are already frequently seen when AppCenter cannot load app icons. I think a better approach would be to use the MIME type icons for images provided by the elementary icon pack.

pthrrr commented 2 years ago

@kdwk On double-click, there is no image, since the user needs to select one. That's why I'm currently using the missing-image-icon.

You probably mean this icon, right?: image

I agree, that it may looks better than that gray-scale icon.

https://user-images.githubusercontent.com/29637548/142260911-6bc22983-b497-47b4-ab93-c82cd8398b66.mp4

kdwk commented 2 years ago

Placeholder icon looks good! Use the filechooser portal for selecting files as well, and it’s good to go.

pthrrr commented 2 years ago

Filechooser portal is already in use. The feature will be part of the next release. I close the issue now.