search

brain-slam / slam

Surface anaLysis And Modeling
MIT License
13 stars 24 forks source link

addind contributors #46

Open alexpron opened 3 years ago

alexpron commented 3 years ago

@all-contributors please add @davidmeunier79 for code, ideas, infra

alexpron commented 3 years ago

@all-contributors please add @davidmeunier79 for code, ideas, infra

allcontributors[bot] commented 3 years ago

@alexpron

I've put up a pull request to add @davidmeunier79! :tada:

EtienneCmb commented 3 years ago

@alexpron the README is a markdown file. I think, in the future you might have some issues between pypi and markdown. In addition, if you use all-contributors inside the README, you can also have troubles to upload with pypi... I had the issue yesterday with Frites and I fixed it by moving the Contributors section to the website. I did this by telling to all-contributors that I prefer to edit my community rst file instead of the README.

There's probably some workaround for uploading to pypi markdown readme. Nevermind, nothing urgent, keep it mind once slam is going to be ready for packaging :)

Thanks for adding me to the contributors <3

m2c

alexpron commented 3 years ago

hello @EtienneCmb indeed I already add some weird troubles with weird merges when adding multi contributors from the same issue. Ty so much for your solution <3 .Actually I wanted to tagg directly visbrain within the tool emoji but it failed. I note it for further improvement 👍

EtienneCmb commented 3 years ago

Hi @alexpron , me too, I also add troubles using the bot. At the end I stopped using it, now I'm using the CLI. I find it more stable but harder to use... Ciao!