search

brain-slam / slam

Surface anaLysis And Modeling
MIT License
13 stars 24 forks source link

Vertex normals #66

Open JulienLefevreMars opened 3 years ago

JulienLefevreMars commented 3 years ago

Hello,

It could be good to add vertex_normal computation directly when one reads a gifti mesh, so in the io.py module. It requires functions of trimesh to compute if from face_normal and avoid redundancies with functions in curvature.py.

Not very long, I can try to do that Julien

alexpron commented 3 years ago

That is a nice idea @JulienLefevreMars to have a fully ready to use mesh ! A solution may be to add a compute_normals or more generic process parameter in the load function to decide either normals should be computed ? This way if the mesh is not pre-processed (I.e. dirty vertices) computation could be disabled. What do you think about it ?

JulienLefevreMars commented 3 years ago

Good point !