rewrite and comment determine_local_basis

brain-slam / slam

Surface anaLysis And Modeling

MIT License

13 stars 24 forks source link

rewrite and comment determine_local_basis #84

Closed JulienLefevreMars closed 2 years ago

JulienLefevreMars commented 2 years ago

Hello,

I have rewritten and commented determine_local_basis in curvature.py . I also removed the proj_matrix inside curvature_fit since it was used only to compute the local basis.

JulienLefevreMars commented 2 years ago

Hey @MaximeDdnn ,

I added precisions on the code and unit tests. Hope it will be clear enough :-)

alexpron commented 2 years ago

I pushed some modifications in your PR @JulienLefevreMars . Just let me know if it 's ok for you @JulienLefevreMars @MaximeDdnn and if yes we can merge the PR