brainandforce / Electrum.jl

A Julian toolkit for solid-state chemical theory.
MIT License
31 stars 0 forks source link

Fixes and testing for `supercell()` #128

Closed brainandforce closed 2 years ago

brainandforce commented 2 years ago

Here's the branch where I'm going to try fixing the issues that come up in #127.

codecov[bot] commented 2 years ago

Codecov Report

Base: 32.47% // Head: 34.95% // Increases project coverage by +2.48% :tada:

Coverage data is based on head (9c03473) compared to base (c56c1aa). Patch coverage: 61.22% of modified lines in pull request are covered.

:exclamation: Current head 9c03473 differs from pull request most recent head 2657e15. Consider uploading reports for the commit 2657e15 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #128 +/- ## ========================================== + Coverage 32.47% 34.95% +2.48% ========================================== Files 16 16 Lines 1275 1319 +44 ========================================== + Hits 414 461 +47 + Misses 861 858 -3 ``` | [Impacted Files](https://codecov.io/gh/brainandforce/Xtal.jl/pull/128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) | Coverage Δ | | |---|---|---| | [src/atoms.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/128/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2F0b21zLmps) | `56.88% <59.09%> (+12.76%)` | :arrow_up: | | [src/lattices.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/128/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2xhdHRpY2VzLmps) | `66.66% <80.00%> (+4.62%)` | :arrow_up: | | [src/show.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/128/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3Nob3cuamw=) | `8.51% <0.00%> (+8.51%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.