brainandforce / Electrum.jl

A Julian toolkit for solid-state chemical theory.
MIT License
31 stars 0 forks source link

Refactor show methods #129

Closed brainandforce closed 2 years ago

brainandforce commented 2 years ago

The code for this was really messy, but I've fixed it up and added a show method for HKLData. I've also added in basis vector printing for ReciprocalSpaceWavefunction.

My main question to @pcross0405 and @xamberl before merging: what other information would be useful to display with the data types you use on a regular basis?

codecov[bot] commented 2 years ago

Codecov Report

Base: 34.86% // Head: 34.29% // Decreases project coverage by -0.56% :warning:

Coverage data is based on head (d77f2db) compared to base (7074f5b). Patch coverage: 3.03% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #129 +/- ## ========================================== - Coverage 34.86% 34.29% -0.57% ========================================== Files 16 16 Lines 1325 1347 +22 ========================================== Hits 462 462 - Misses 863 885 +22 ``` | [Impacted Files](https://codecov.io/gh/brainandforce/Xtal.jl/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) | Coverage Δ | | |---|---|---| | [src/show.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3Nob3cuamw=) | `6.89% <3.03%> (-1.62%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

xamberl commented 2 years ago

I'm not sure what else I need in the future, but I think the shown information should be sufficient.for now

brainandforce commented 2 years ago

Even though this fails checks, I'm just gonna merge it since the testing is otherwise fine.