brainandforce / Electrum.jl

A Julian toolkit for solid-state chemical theory.
MIT License
31 stars 0 forks source link

Refactoring of show methods #132

Closed brainandforce closed 1 year ago

brainandforce commented 1 year ago

I've cleaned up a good amount of the code and added some extra functionality: now formula string printing is supported for AtomList and AbstractCrystal. Most of these changes involve internal APIs so users shouldn't really be affected besides that.

codecov[bot] commented 1 year ago

Codecov Report

Base: 34.29% // Head: 34.20% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (ed486de) compared to base (684d36f). Patch coverage: 8.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #132 +/- ## ========================================== - Coverage 34.29% 34.20% -0.10% ========================================== Files 16 16 Lines 1347 1345 -2 ========================================== - Hits 462 460 -2 Misses 885 885 ``` | [Impacted Files](https://codecov.io/gh/brainandforce/Xtal.jl/pull/132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) | Coverage Δ | | |---|---|---| | [src/Xtal.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL1h0YWwuamw=) | `50.00% <ø> (ø)` | | | [src/show.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3Nob3cuamw=) | `6.89% <0.00%> (ø)` | | | [src/atoms.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2F0b21zLmps) | `53.98% <100.00%> (-0.81%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.