search

brainandforce / Electrum.jl

A Julian toolkit for solid-state chemical theory.
MIT License
31 stars 0 forks source link

Phonons #134

Closed xamberl closed 1 year ago

xamberl commented 1 year ago

Added function to read phonon DOS.

codecov[bot] commented 1 year ago

Codecov Report

Base: 32.47% // Head: 31.89% // Decreases project coverage by -0.57% :warning:

Coverage data is based on head (bc874c5) compared to base (c387809). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #134 +/- ## ========================================== - Coverage 32.47% 31.89% -0.58% ========================================== Files 16 16 Lines 1398 1417 +19 ========================================== - Hits 454 452 -2 - Misses 944 965 +21 ``` | [Impacted Files](https://codecov.io/gh/brainandforce/Xtal.jl/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) | Coverage Δ | | |---|---|---| | [src/Xtal.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL1h0YWwuamw=) | `50.00% <ø> (ø)` | | | [src/software/abinit.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3NvZnR3YXJlL2FiaW5pdC5qbA==) | `44.64% <0.00%> (-2.09%)` | :arrow_down: | | [src/data/realspace.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2RhdGEvcmVhbHNwYWNlLmps) | `30.55% <0.00%> (-3.70%)` | :arrow_down: | | [src/data/reciprocalspace.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2RhdGEvcmVjaXByb2NhbHNwYWNlLmps) | `13.60% <0.00%> (-2.53%)` | :arrow_down: | | [src/vectors.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3ZlY3RvcnMuamw=) | | | | [src/math.jl](https://codecov.io/gh/brainandforce/Xtal.jl/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL21hdGguamw=) | `44.44% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

brainandforce commented 1 year ago

Can you try locally rebasing this branch on main and force pushing to see if that resolves the merge conflict? If it doesn't we'll go over this together

brainandforce commented 1 year ago

Also, don't worry about the codecov/patch test yet. Right now we're low on testing, and adding features will decrease the coverage, but I'll run you through testing later.