brainandforce / Electrum.jl

A Julian toolkit for solid-state chemical theory.
MIT License
31 stars 0 forks source link

Fix `incrementHKL` to stay within bounds #139

Closed xamberl closed 1 year ago

xamberl commented 1 year ago

Fixes incrementHKL! in the readWAVECAR function where it goes out of bounds (+1).

codecov[bot] commented 1 year ago

Codecov Report

Base: 31.85% // Head: 31.85% // No change to project coverage :thumbsup:

Coverage data is based on head (7a25a89) compared to base (afa91eb). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #139 +/- ## ======================================= Coverage 31.85% 31.85% ======================================= Files 16 16 Lines 1419 1419 ======================================= Hits 452 452 Misses 967 967 ``` | [Impacted Files](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) | Coverage Δ | | |---|---|---| | [src/Electrum.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL0VsZWN0cnVtLmps) | `50.00% <ø> (ø)` | | | [src/data/atomic.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2RhdGEvYXRvbWljLmps) | `0.00% <ø> (ø)` | | | [src/data/realspace.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2RhdGEvcmVhbHNwYWNlLmps) | `30.55% <ø> (ø)` | | | [src/filetypes.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2ZpbGV0eXBlcy5qbA==) | `41.47% <0.00%> (ø)` | | | [src/lattices.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2xhdHRpY2VzLmps) | `66.66% <ø> (ø)` | | | [src/math.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL21hdGguamw=) | `44.44% <ø> (ø)` | | | [src/show.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3Nob3cuamw=) | `6.83% <ø> (ø)` | | | [src/software/abinit.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3NvZnR3YXJlL2FiaW5pdC5qbA==) | `45.59% <ø> (ø)` | | | [src/software/lammps.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3NvZnR3YXJlL2xhbW1wcy5qbA==) | `0.00% <0.00%> (ø)` | | | [src/software/vasp.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3NvZnR3YXJlL3Zhc3Auamw=) | `12.38% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.