Closed brainandforce closed 1 year ago
Patch coverage has no change and project coverage change: +0.07
:tada:
Comparison is base (
d3bdfe9
) 51.68% compared to head (c5a447b
) 51.76%.:exclamation: Current head c5a447b differs from pull request most recent head 341a967. Consider uploading reports for the commit 341a967 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for the comments. I do want to say that I noted differences in the header information over different versions of ABINIT and anaddb. The this function will need to be rewritten later to accommodate this.
I'm going to push this change to main
since the functions are not exported and they'll need to be rewritten anyway.
I noticed that some of the methods for abinit file writing didn't conform to the (informal, undocumented) standard for file processing methods. Along with having the methods comply with that standard, I refactored them slightly and included some comments for improvement. I realize I should have been more proactive with that feedback earlier on. Since I don't work with anaddb I'd like to get your feedback before merging.
As a future note, I'm going to include some extra documentation for how to contribute file writing methods. The tl;dr is that every file writing function should have a method that accepts a file handle (Julia
IO
subtypes, see the method signatures that contain(io::IO, args...; kwargs...)
) and then another method that accepts a path. By default we assumed that this was anAbstractString
, but some packages provide a custom type for paths, so in the future there will be no type restriction.