Closed brainandforce closed 1 year ago
I think I need to update the generation of documentation as well...leaving this here for future me
Patch coverage: 29.85
% and project coverage change: +0.01
:tada:
Comparison is base (
cb931ab
) 30.79% compared to head (597ee25
) 30.80%.:exclamation: Current head 597ee25 differs from pull request most recent head c921fb5. Consider uploading reports for the commit c921fb5 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
RealSpaceDataGrid
andHKLData
should have subtypedAbstractArray
to begin with. I've done this and simplified a vast number of the method definitions. Both these types now subtypes now subtypeAbstractDataGrid
which itself subtypesAbstractArray
, so a good number of methods that arrays should have are already defined.In practice, this may not break anything, but the relationships betwen the types is different. Also,
AbstractCrystalData
,AbstractRealSpaceData
, andAbstractReciprocalSpaceData
are now gone, as they served no real purpose. So hasgrid()
- nowconvert(::Type{<:Array}, ::AbstractDataGrid)
is defined.I don't think linear indexing is needed for these types, just with the internals.