search

brainandforce / Electrum.jl

A Julian toolkit for solid-state chemical theory.
MIT License
31 stars 0 forks source link

Fixed indexing for `KPointList` #151

Closed brainandforce closed 1 year ago

brainandforce commented 1 year ago

Now if a range of k-points is used as the index, the object returned is another KPointList. This is a temporary fix as #150 should completely rework a lot of the KPointList internals.

But I've also included pretty printing methods for KPointList which should be relevant even afterwards.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 15.38% and project coverage change: -0.16 :warning:

Comparison is base (67538bb) 32.75% compared to head (011da9f) 32.59%.

:exclamation: Current head 011da9f differs from pull request most recent head 2f0649b. Consider uploading reports for the commit 2f0649b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #151 +/- ## ========================================== - Coverage 32.75% 32.59% -0.16% ========================================== Files 18 18 Lines 1435 1442 +7 ========================================== Hits 470 470 - Misses 965 972 +7 ``` | [Impacted Files](https://codecov.io/gh/brainandforce/Electrum.jl/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) | Coverage Δ | | |---|---|---| | [src/show.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3Nob3cuamw=) | `0.00% <0.00%> (ø)` | | | [src/data/reciprocalspace.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2RhdGEvcmVjaXByb2NhbHNwYWNlLmps) | `10.52% <33.33%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.