brainandforce / Electrum.jl

A Julian toolkit for solid-state chemical theory.
MIT License
31 stars 0 forks source link

Adding testing for `AbstractCrystal` types #152

Closed brainandforce closed 1 year ago

brainandforce commented 1 year ago

There's a lack of testing for these data types and their associated functions, so I'm adding more.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.29 :tada:

Comparison is base (7e655cc) 32.91% compared to head (0545b88) 34.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ========================================== + Coverage 32.91% 34.21% +1.29% ========================================== Files 18 18 Lines 1443 1441 -2 ========================================== + Hits 475 493 +18 + Misses 968 948 -20 ``` | [Impacted Files](https://codecov.io/gh/brainandforce/Electrum.jl/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) | Coverage Δ | | |---|---|---| | [src/atoms.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2F0b21zLmps) | `60.17% <100.00%> (+1.76%)` | :arrow_up: | | [src/crystals.jl](https://codecov.io/gh/brainandforce/Electrum.jl/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2NyeXN0YWxzLmps) | `59.45% <100.00%> (+38.94%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/brainandforce/Electrum.jl/pull/152/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.