brainandforce / Electrum.jl

A Julian toolkit for solid-state chemical theory.
MIT License
31 stars 0 forks source link

Depreciates `readKPOINTS` #159

Closed xamberl closed 1 year ago

brainandforce commented 1 year ago

So there's a new Julia release out (1.9.0 - I'll make sure our computers are upgraded) and that might be why our tests are failing. I'll see if this is causing problems.

brainandforce commented 1 year ago

I removed the export for readKPOINTS() which was causing the failure.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.99 :tada:

Comparison is base (031838b) 48.06% compared to head (eb12d4b) 49.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #159 +/- ## ========================================== + Coverage 48.06% 49.06% +0.99% ========================================== Files 17 17 Lines 1344 1335 -9 ========================================== + Hits 646 655 +9 + Misses 698 680 -18 ``` | [Impacted Files](https://app.codecov.io/gh/brainandforce/Electrum.jl/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) | Coverage Δ | | |---|---|---| | [src/Electrum.jl](https://app.codecov.io/gh/brainandforce/Electrum.jl/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL0VsZWN0cnVtLmps) | `66.66% <ø> (+16.66%)` | :arrow_up: | | [src/software/vasp.jl](https://app.codecov.io/gh/brainandforce/Electrum.jl/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3NvZnR3YXJlL3Zhc3Auamw=) | `49.73% <ø> (+3.46%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/brainandforce/Electrum.jl/pull/159/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.