Closed brainandforce closed 1 year ago
Patch coverage: 66.66
% and no project coverage change.
Comparison is base (
d90478b
) 49.10% compared to head (6a955b3
) 49.10%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Until now there were pairs of functions that did the same thing:
read_abinit_density()
andread_abinit_DEN()
,read_abinit_potential()
andread_abinit_POT()
, andread_abinit_wavefunction()
andread_abinit_WFK()
.My future design plan is to have functions like
read_abinit_density()
return only the associated datagrid, andread_abinit_DEN()
return the datagrid as part of aCrystalWithDatasets
(or perhaps a similar future type that replaces it). So the aliasing of function names is being dropped.@xamberl I'm going to loop you in on this