brainandforce / Electrum.jl

A Julian toolkit for solid-state chemical theory.
MIT License
31 stars 0 forks source link

`read_abinit_WFK` stores k-point mesh correctly #192

Closed brainandforce closed 1 year ago

brainandforce commented 1 year ago

Previously we noticed that read_abinit_WFK did not store the KPointMesh from the header data. This should fix #191.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fd86efb) 58.60% compared to head (0a4ba9f) 59.17%.

:exclamation: Current head 0a4ba9f differs from pull request most recent head d5d5167. Consider uploading reports for the commit d5d5167 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #192 +/- ## ========================================== + Coverage 58.60% 59.17% +0.57% ========================================== Files 19 19 Lines 1406 1411 +5 ========================================== + Hits 824 835 +11 + Misses 582 576 -6 ``` | [Files](https://app.codecov.io/gh/brainandforce/Electrum.jl/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores) | Coverage Δ | | |---|---|---| | [src/data/wavefunctions.jl](https://app.codecov.io/gh/brainandforce/Electrum.jl/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL2RhdGEvd2F2ZWZ1bmN0aW9ucy5qbA==) | `75.00% <100.00%> (+2.69%)` | :arrow_up: | | [src/software/abinit.jl](https://app.codecov.io/gh/brainandforce/Electrum.jl/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Flores#diff-c3JjL3NvZnR3YXJlL2FiaW5pdC5qbA==) | `48.74% <83.33%> (+1.90%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.